search

lxqt / libqtxdg

Qt implementation of freedesktop.org xdg specs
https://lxqt.github.io
GNU Lesser General Public License v2.1
72 stars 35 forks source link

Fix chronic memory leak #201

Closed stream009 closed 4 years ago

stream009 commented 4 years ago

You can confirm memory leak by

  1. launch lxqt-panel (with main menu plugin) or lxqt-runner
  2. check memory usage with ps or top
  3. trigger menu rebuild with $ sudo touch /usr/share/applications (or equivalent depend on distro)
  4. repeat 2 for some time with few seconds interval
  5. observe RSS + Swap increase
tsujan commented 4 years ago

@palinek, your patch is much cleaner and removes lots of valgrind's "definitely lost" warnings about XdgMenu::read and XdgDesktopFile::isShown. Would you please make a superseding PR?

@stream009, thank you very much for finding the memory leak!

palinek commented 4 years ago

Would you please make a superseding PR?

221

tsujan commented 4 years ago

Superseded by https://github.com/lxqt/libqtxdg/pull/221. Closing.