Workaround for the bug of Qt 5.15 in `QMouseEvent::buttons()` with `QMenu`

lxqt / libqtxdg

Qt implementation of freedesktop.org xdg specs

https://lxqt.github.io

GNU Lesser General Public License v2.1

72 stars 35 forks source link

Workaround for the bug of Qt 5.15 in `QMouseEvent::buttons()` with `QMenu` #214

Closed tsujan closed 4 years ago

tsujan commented 4 years ago

Closes https://github.com/lxqt/lxqt/issues/1821

Although this workaround works fine, I'm not sure if we should merge it. @luis-pereira, shouldn't we wait for a fix in Qt instead (even if it doesn't come soon)?

luis-pereira commented 4 years ago

@tsujan It works just fine. Yes, Qt developers should fix that. It can wait, unless we start to receive a "lot's" of bug reports.

tsujan commented 4 years ago

OK. So, let's keep it here without merging for a while. We could decide what to do if the bug isn't fixed when LXQt 0.16 is going to be released.

QGuiApplication::mouseButtons() seems reliable here because it's updated after a mouse button is pressed or released.

yan12125 commented 4 years ago

Closing as the issue has been fixed with Qt 5.15.1