Look into Qt "Fix double scaling of SVG icons on high DPI screens"

lxqt / libqtxdg

Qt implementation of freedesktop.org xdg specs

https://lxqt.github.io

GNU Lesser General Public License v2.1

72 stars 35 forks source link

Look into Qt "Fix double scaling of SVG icons on high DPI screens" #224

Closed luis-pereira closed 4 years ago

luis-pereira commented 4 years ago

@tsujan You did some work in ScalableEntry::pixmap(). Can you check if https://code.qt.io/cgit/qt/qtbase.git/commit/src/gui/image/qiconloader.cpp?id=d8ab719c0890195cfce0fb6d4c76b3664d6f3a9d applies to us ?

Expected Behavior

Current Behavior

Possible Solution

Context

System Information

Distribution & Version:
Kernel:
Qt Version:
cmake Version:
lxqt-build-tools Version:
Package version:

tsujan commented 4 years ago

@luis-pereira After https://github.com/lxqt/libqtxdg/pull/203 (which may be seen as a workaround for a Qt bug), there is no problem with SVG+scaling in LXQt. An example with a ridiculous scale factor of 5:

svg_icons

But it's good to see what Qt devs have done and whether it's relevant to our code. Thanks for the link! Will look into it as soon as I find the time.

tsujan commented 4 years ago

@luis-pereira The final result is the same but their fix is better than my workaround. So, I made a PR: https://github.com/lxqt/libqtxdg/pull/225