Closed luis-pereira closed 3 years ago
To be merge after the 0.16 release
The code looks good. Will test it tomorrow.
Shouldn't be bumping the .so version part of this PR?
Shouldn't be bumping the .so version part of this PR?
It's usually done before the next release -- at least, that has been the case with libfm-qt.
EDIT: The reason is that more code change might happen.
In addition to @tsujan comments, the class in question wasn't used. But it deserves a note in the commit message. Will updated it.
Deprecated roughly two years ago. It's time to let it go.