lxqt / libqtxdg

Qt implementation of freedesktop.org xdg specs
https://lxqt.github.io
GNU Lesser General Public License v2.1
72 stars 35 forks source link

Remove deprecated XdgDesktopFileCache #235

Closed luis-pereira closed 3 years ago

luis-pereira commented 3 years ago

Deprecated roughly two years ago. It's time to let it go.

luis-pereira commented 3 years ago

To be merge after the 0.16 release

tsujan commented 3 years ago

The code looks good. Will test it tomorrow.

palinek commented 3 years ago

Shouldn't be bumping the .so version part of this PR?

tsujan commented 3 years ago

Shouldn't be bumping the .so version part of this PR?

It's usually done before the next release -- at least, that has been the case with libfm-qt.

EDIT: The reason is that more code change might happen.

luis-pereira commented 3 years ago

In addition to @tsujan comments, the class in question wasn't used. But it deserves a note in the commit message. Will updated it.