Don't shadow variables - Githubissues

lxqt / libqtxdg

Qt implementation of freedesktop.org xdg specs

https://lxqt.github.io

GNU Lesser General Public License v2.1

72 stars 35 forks source link

Closed luis-pereira closed 3 years ago

luis-pereira commented 3 years ago

A local variable shouldn't shadow a outer variable.

tsujan commented 3 years ago

It had no problem, IMHO, but yes, avoiding it may prevent confusion for the code reader. GTM

luis-pereira commented 3 years ago

The compiler keeps track of the scope. But the reader, might not. This is a readability issue, of course.