Closed tsujan closed 11 months ago
Also, you may want to take a look at https://github.com/lxqt/lxqt-panel/issues/1661#issuecomment-917721942
Already wrote a complete patch to xdg-utils
. Will publish it here next week. Wait for comments and reviews and after that submit it to upstream xdg-utils
.
@tsujan Real life get's in the way. But it's ready for testing, now.
Pls try the enhance-lxqt-support
branch at my fork from upstream xdg-utils.
After positive feedback I will make a merge request.
@luis-pereira Many thanks!
I applied your patch (https://gitlab.freedesktop.org/luis-pereira/xdg-utils/-/commit/d2adf5efdc259a63028f8d4f21569c1557b8cfff) to xdg-utils
1.1.3+19+g9816ebb. Everything seems OK; https://github.com/lxqt/lxqt-panel/issues/1661 isn't reproducible anymore.
I'll use it for a few days and report back.
@stefonarch, could you also confirm that https://gitlab.freedesktop.org/luis-pereira/xdg-utils/-/commit/d2adf5efdc259a63028f8d4f21569c1557b8cfff fixes https://github.com/lxqt/lxqt-panel/issues/1661 without ~/.local/share/applications/defaults.list
?
Ok, looks like this filelight error doesn't show up anymore now. Will test for some days.
@luis-pereira I haven't encountered any problem with your patch after three days.
I haven't encountered any problem with your patch after three days.
Nice.
@stefonarch Do you have any feedback on this ?
In case you also want to know what I see here after 17 days, it's the same as before: have encountered no problem.
Sorry thought I'd said it somewhere: no issues encountered all those days.
After positive feedback I will make a merge request.
News about that?
News about that?
@luis-pereira made the merge request 5 months ago: https://gitlab.freedesktop.org/xdg/xdg-utils/-/merge_requests/48. But apparently there's a problem ("Merge blocked: the source branch must be rebased onto the target branch.")
@tsujan @stefonarch I will rebase after the weekend. There weren't any merge conflicts when I made the merge request.
There weren't any merge conflicts when I made the merge request.
I know; saw it only today.
Rebased.
Upstream xdg-utils seems no so active. I'm afraid the patch will not be merged soon. I uploaded https://aur.archlinux.org/packages/xdg-utils-lxqt, so users on Arch-like systems can use the patched version easily.
Upstream xdg-utils seems no so active.
Can't we explicitly request a review there?
I didn't find a button for requesting a reviewer on GitLab. I just pinged the one who merged recent merge requests and hopefully that will work. Both https://gitlab.freedesktop.org/xdg/xdg-utils/-/merge_requests/29 and https://gitlab.freedesktop.org/xdg/xdg-utils/-/merge_requests/42 were merged by https://gitlab.freedesktop.org/faure, on Dec 2020 and Feb 2022, respectively.
We're out of luck; the patch has a conflict again: https://gitlab.freedesktop.org/xdg/xdg-utils/-/merge_requests/48
Very good news! Now xdg-open
is reliable under LXQt, through and besides qtxdg-mat
:)
This isn't a bug in LXQt but an urgent need.
Currently,
xdg-open
only usesopen_generic
under LXQt, causing troubles like https://github.com/lxqt/lxqt-panel/issues/1661.@luis-pereira made
qtxdg-mat
. It should be used inxdg-open
under LXQt.