search

lxqt / libqtxdg

Qt implementation of freedesktop.org xdg specs
https://lxqt.github.io
GNU Lesser General Public License v2.1
72 stars 35 forks source link

Fixed a bug in supporting string literals in Exec keys #276

Closed tsujan closed 2 years ago

tsujan commented 2 years ago

The code partially affected non-Exec keys too. This patch solves the problem by fully separating Exec keys from others.

Fixes https://github.com/lxqt/lxqt-panel/issues/1737

tsujan commented 2 years ago

You did a great detective job, finding the problem with apostrophe. I enjoyed it.

tor browser desktop file works still too.

Yes, I didn't touch that part of https://github.com/lxqt/libqtxdg/pull/271.

tsujan commented 2 years ago

I'll merge it tomorrow; want to take another look at it when I'm not drowsy ;)

stefonarch commented 2 years ago

You did a great detective job, finding the problem with apostrophe. I enjoyed it.

I enjoyed it too - in the moment when I found it. But it was @slidinghotdog who gave the final hint.

tsujan commented 2 years ago

But it was @slidinghotdog who gave the final hint.

Yes. He and I thought about the same thing almost simultaneously. But 90% of the problem was already solved by your finding.