search

lxqt / libqtxdg

Qt implementation of freedesktop.org xdg specs
https://lxqt.github.io
GNU Lesser General Public License v2.1
72 stars 35 forks source link

Tools split #278

Closed luis-pereira closed 2 years ago

tsujan commented 2 years ago

@yan12125 made a very good point at https://github.com/lxqt/lxqt/discussions/2139; I almost forgot about lxqt-qtxdg.conf and qtxdg.conf, although I'd skipped them alongside qtxdg-mat in https://github.com/lxqt/libqtxdg/pull/272.

It seems to me that we have to move them to qtxdg-tools too.

tsujan commented 2 years ago

@luis-pereira Please merge it if it's ready.

yan12125 commented 2 years ago

Tested - the new CMake option work as intended, thanks!

tsujan commented 2 years ago

If we merge this before LXQt 1.1.0, we should also merge https://github.com/lxqt/qtxdg-tools/pull/2 and add qtxdg-tools as a dependency to lxqt-session (because xdg-utils will need it under an LXQt session when https://gitlab.freedesktop.org/xdg/xdg-utils/-/merge_requests/48 is merged).

tsujan commented 2 years ago

Please do not merge this PR before LXQt 1.1.0 is released! We will discuss it soon.

EDIT: Done.

tsujan commented 2 years ago

I wonder why GitHub doesn't show a merge conflict here! This is impossible now:

- set(QTXDG_MINOR_VERSION 8)
+ set(QTXDG_MINOR_VERSION 9)

EDIT: The answer can be, "because the branch has no conflict with the master."

tsujan commented 2 years ago

Added a commit for bumping LXQTBT_MINIMUM_VERSION to 0.11.0.

I'll set QTXDG_PATCH_VERSION to 1 when making prerelease changes.

tsujan commented 2 years ago

After a commit for updating CHANGELOG, I think it's completely rebased now.

tsujan commented 2 years ago

Merging?

yan12125 commented 2 years ago

Go ahead!