search

lxqt / libqtxdg

Qt implementation of freedesktop.org xdg specs
https://lxqt.github.io
GNU Lesser General Public License v2.1
72 stars 35 forks source link

Fixed file association with symlink desktop entries #288

Closed tsujan closed 1 year ago

tsujan commented 1 year ago

Previously, the (final) targets of symlink desktop entries were loaded and failed to meet the requirements of mime-type association. The patch solves the problem by loading the symlinks themselves.

I didn't find any side effect in the code or in practice. The only difference I've found is that, if a menu item corresponding to a symlink desktop entry is dragged and dropped, it'll be created as a symlink, not as its target — which isn't a problem and seems more natural to me.

Fixes https://github.com/lxqt/libqtxdg/issues/287 and closes https://github.com/lxqt/lxqt-config/issues/897

tsujan commented 1 year ago

Any objection to merging? It can be tested as described in https://github.com/lxqt/libqtxdg/issues/287 and https://github.com/lxqt/lxqt-config/issues/897.

EDIT: A point release may also be needed.

stefonarch commented 1 year ago

I had no issue, *.csv was assigned to Libreoffice calc, now I changed to featherpad and couldn't switch back...

So 1) issue confirmed 2) patch is working fine.

tsujan commented 1 year ago

Thanks for the confirmation.

The issue is very old. It has been hidden perhaps because symlinks are rare inside /usr/share/applications.