Made directories under "Technical Info" clickable

[tsujan]

Only if they exist.

Closes https://github.com/lxqt/lxqt-about/issues/238

[tsujan]

Any objection to merging? <br> is also removed when copying to clipboard.

[stefonarch]

Tested only now, GTM, only existing directories are links. BTW we should get rid of LXQt-about version there in favour of libqtxdg version which doesn't follow the 1.* scheme.

[tsujan]

Thanks!

BTW we should get rid of LXQt-about version there in favour of libqtxdg version which doesn't follow the 1.* scheme.

Although the patch version of LXQt About doesn't seem important, suppose there's a critical bug in its version 1.2.0 (very unlikely but we're fallible human beings). Then, we don't want to change the version of LXQt because of that; we just want to release the fixed LXQt-About 1.2.1. That's like other components.

[stefonarch]

But who cares of the version of LXQt-about at all? It isn't involved in any other components. So we should include all components versions following this logic.

[tsujan]

But who cares of the version of LXQt-about at all?

In the unlikely case of a critical bug, it makes sense (dev asks user, "Do you have lxqt-about 1.2.1 or the buggy 1.2.0?").

[tsujan]

So we should include all components versions following this logic.

Oh, we already do; don't we?

[tsujan]

For example, see the main CMakeLists.txt file of lxqt-panel. lxqt-panel depends on LXQt; therefore, its major and minor versions are taken from LXQt. But its patch version (LXQT_PANEL_PATCH_VERSION) is set manually, independently of LXQt.

In pcmanfm-qt, all version parts are set manually because it doesn't depend on LXQt. However, the major and minor versions are set to be those of LXQt, for the sake of consistency (it's a major LXQt component).

[stefonarch]

So we should include all components versions following this logic.

Oh, we already do; don't we?

We had LXQt 1.0 with lxqt-session 1.0.1 if I remember well

[tsujan]

I wonder why ~/.local/share/lxqt/translations is included. Installation inside user home?

[stefonarch]

No idea, I thought it was default as one of the 3 dirs which will be read, in order. Checked in my Virtualbox installations, it's included too, so yes. You don't have it?

[tsujan]

You don't have it?

No, I don't.

Frankly, I haven't had time to check it. Logically, it's expected that LXQt apps that don't depend on LXQt (like pcmanfm-qt) shouldn't use it, but apps like lxqt-panel should. Doesn't lxqt-panel give priority to that folder for loading its translations? Have you tested?

[stefonarch]

I remember that it worked for all lxqt components but not apps. I sent an archive to the arabic translator and it worked for him too, saving them locally, but didn't test recently myself.

I checked now my ubuntu VM and there I see twice /usr/share/lxqt/translation, while in the debian VM it was the same as in arch on the laptop and in debian on my PC, order is ~/.local - /usr/local/share ./usr/share as it should be.

[tsujan]

I remember that it worked for all lxqt components but not apps.

So, everything may be OK. Most probably, those LXQt apps didn't depend on LXQt.

I checked now my ubuntu VM and there I see twice /usr/share/lxqt/translation

Probably a path is added twice by the system/user there. If it happens frequently, we could remove duplicates in lxqt-about.

[stefonarch]

Usually it adds all 3 paths, independently of existing or not. Didn't look at the code though.

[tsujan]

The code uses liblxqt's LXQt::Translator::translationSearchPaths(), which removes duplicates.

[stefonarch]

Any idea why you don't have the ~/.local one?

[tsujan]

You mean ~/.local/share/lxqt/translations. It's simple: I've never created it because I didn't need it.

Actually, I don't have /usr/share/lxqt/translations either because I include translations in compilation only for libfm-qt, pcmanfm-qt, lximage-qt and qterminal (to test some things in them). With LXQt-dependent apps, I don't include translations.

[stefonarch]

I meant "why don't you have it listed". /usr/local/share/lxqt/translations/ does not exist and is also always listed.

[tsujan]

I meant "why don't you have it listed".

I do:

/usr/local/share/lxqt/translations/ does not exist and is also always listed.

lxqt-about lists the paths that liblxqt has set. The only difference this patch has made is that the existing paths can be opened.

EDIT: When I said, "I don't have /usr/share/lxqt/translations...", I meant I don't have that folder; but it's listed here.

EDIT1: Apparently, my words were confusing (the existence of folders vs. being in the list).

[stefonarch]

Apparently, my words were

I misunderstood that it wasn't listed indeed, so much do about nothing here ;)