Closed ArrayBolt3 closed 2 months ago
If I understood you that's about the desktop grid. I can't reproduce, still if I got it right (actually this is on hyprland). Not an openbox issue?
https://github.com/user-attachments/assets/6da02cf6-fb6c-4c04-a973-031bffb028f6
@ArrayBolt3, what do you mean by "icon theme grid"? You could attach screenshots if you don't find the exact words.
sorry, I intended to attach screenshots and then just forgot to.
Before:
After selecting a new theme and clicking "Apply":
I doubt this is Openbox-related though I can test with xfwm4.
Thanks for the screenshot. So, it isn't about Desktop but the window itself.
I doubt this is Openbox-related
No, this isn't related to Openbox or any WM but, most probably, to Qt 6.6.X.
As you can see that's not the case in my video. But I can reproduce it with any WM in Debian WM with Qt 6.6.2
OK. I'm closing this because we can't reproduce it with Qt 6.7.2.
@ArrayBolt3 If your Qt version is upgraded to ≥ 6.7.2 and you can still reproduce it, please tell us to reopen the issue. Thanks for reporting!
Sadly Qt 6.7+ isn't an option for Ubuntu this cycle, so I guess I'll look into patching this downstream. Thanks for your help!
Sadly Qt 6.7+ isn't an option for Ubuntu this cycle,
That's unfortunate. I remember that Qt 6.6 had problems that were fixed in 6.7, although I don't remember what they were.
I think we never noticed it as users won't change icons often.
Expected Behavior
Selecting a new icon theme in lxqt-config-appearance and clicking "Apply" should result in the icon theme being changes and the change persisting. It should NOT cause any unintentional side effects to the icon theme grid.
Current Behavior
Same as expected, except for the icon theme grid's columns grow after clicking "Apply", causing elements to go off the right side of the screen.
Possible Solution
I don't have any good ideas for solutions, but this is what I tried so far:
I debugged the code from
master
and narrowed the issue down tolxqt-config-appearance/iconthemeconfig.cpp
, functionIconThemeConfig::applyIconTheme
:Commenting out this line of code, then rebuilding and reinstalling lxqt-config, causes the icon theme changer to no longer function properly, but it also causes the strange resizing of columns to stop. The issue persists even if I comment out any or all of the other lines in the
if
statement this line of code is found in, whereas commenting out that line and only that line is enough to resolve the issue.I attempted to copy the
resizeColumnToContents
loop from the end ofinitIconThemes
and putting it in theapplyIconTheme
function, pasting it just under them_settings->sync()
line. This did not resolve the issue. I also tried clearingiconThemeList
before settings its column count ininitIconThemes()
, then callinginitIconThemes()
in theapplyIconTheme
function. This also did not work... unless I selected and applied the same icon theme twice in a row. The first apply would break it, the second apply would fix it. I also tried removing theresizeColumnToContents
loop frominitIconThemes
entirely, which just resulted in the table looking broken out of the starting gate.My guess is that calling
m_settings->setValue()
is emitting a signal that somehow refreshes the icon theme table (how, I do not know). That event probably is failing to resize the column, resulting in the breakage. That would make sense of why setting the column sizes inapplyIconTheme
wouldn't work, since the signal wouldn't be handled until afterapplyIconTheme
was finished executing. Unfortunately I've not been able to find where the signal is that's causing the problem.Steps to Reproduce (for bugs)
Context
Looks weird in Lubuntu 24.10.
System Information