search

lxqt / lxqt-config

Tools to configure LXQt and the underlying operating system
https://lxqt.github.io
GNU Lesser General Public License v2.1
83 stars 61 forks source link

Make sure Monitor Settings dialog is shown completely on Wayland #1042

Closed tsujan closed 3 weeks ago

tsujan commented 3 weeks ago

This is rather a simple workaround for undersized dialogs on Wayland (a new Qt bug), but it's good on X11 too.

tsujan commented 3 weeks ago

The goal isn't setting the size but circumventing the Qt bug. A "good" size is different for different users and depends on locale, font, style,...

stefonarch commented 3 weeks ago

I bet 99% of the users have to increase the size and it will not be remembered (at least on kwin).

tsujan commented 3 weeks ago

it will not be remembered

That's a totally separate topic. I prefer to make a separate PR for it after this is merged.

stefonarch commented 3 weeks ago

Ok. I think we should also change the message at login, will look into it. It's way too talkative IMO.

tsujan commented 3 weeks ago

It's way too talkative IMO.

This short message is verbose?

LXQt monitor settings are currently unsupported under this wayland compositor.

You can configure your monitor(s) with kanshi.

stefonarch commented 3 weeks ago

No, this one: Default monitor settings have been applied. Use lxqt-config-monitor for adjusting your monitor settings. And you see it at every login with kwin and it makes saved notifications talking more then half the screen too.

It's even wrong as it applies saved settings not default ones.

tsujan commented 3 weeks ago

And you see it at every login

It's shown only when saved configs can't be applied, and that's a sign of problem. The message clearly tells that the user needs to change his saved settings or remove them to get rid of it.

If it's shown in another case, the code should be corrected.

tsujan commented 3 weeks ago

I found no problem in the main code. However, it's better to change the notification to

                        mNotification->setSummary(tr("Default monitor settings applied."));
                        mNotification->setBody(tr("Use lxqt-config-monitor for adjusting your monitor settings."));