search

lxqt / lxqt-config

Tools to configure LXQt and the underlying operating system
https://lxqt.github.io
GNU Lesser General Public License v2.1
86 stars 60 forks source link

lxqt-config-monitor: Change dialog button from QToolButton to QPushButton #1047

Open isf63 opened 2 months ago

isf63 commented 2 months ago

Change the "Settings" dialog button to a QPushButton. This simplifies the Designer UI file and fixes text/icon alignment (for example on Fusion.)

isf63 commented 2 months ago

liblxqt uses QDialogButtonBox which itself uses QPushButton.

Re:

and fixes text/icon alignment (for example on Fusion.)

QToolButton has different (and in my opinion, worse) styling than QPushButton.

buttons

tsujan commented 2 months ago

fixes text/icon alignment

I'm afraid there's nothing to fix. It's like saying, "Don't use tabs because they look ugly with Fusion."

isf63 commented 2 months ago

QToolButton is styled differently in most Qt styles. Logically dialog buttons should be consistently QPushButton as that is what liblxqt uses.

tsujan commented 2 months ago

IMO, in no way should a code avoid using a widget because of how it's drawn by this or that Qt style.

isf63 commented 2 months ago

Apart from that, it simplifies the Designer UI and makes consistent use of QPushButton in dialog boxes. No functional changes other than its drawing by Qt styles.

I think these benefits are pretty uncontroversial.