search

lxqt / lxqt-config

Tools to configure LXQt and the underlying operating system
https://lxqt.github.io
GNU Lesser General Public License v2.1
81 stars 62 forks source link

Separate page for GTK settings #817

Closed ghost closed 2 years ago

ghost commented 2 years ago

Currently in lxqt-config-appearance there is a scrollbar on small resolutions for the sub-pane "Widget Style".

Perhaps GTK styling could be moved to it's own sub-pane? Whatever could be done, I believe there is too many things in the "Widget Style" sub-pane currently.

This would help users of screens with resolution e.g. 1366x768.

stefonarch commented 2 years ago

We did a similar thing with the panel config menu already. https://lxqt-project.org/blog/2022/02/14/lxqt-1.1.0-preview/

There was a discussion about lxqt-config-appearance window elements and some reordering, I cannot find it atm. Because gtk settings apply also fonts and that is not clear.

gtk.integration in dedicated subpane could be a solution.

tsujan commented 2 years ago

We did a similar thing with the panel config menu already.

This is different. GTK theme is the non-native part of "Widget Style" and, IMO, should remain there. Scrollbars exist to be used when needed.

That being said, we can make the "Widget Style" page tabbed and move the GTK theme settings to the second tab.

stefonarch commented 2 years ago

But widget style isn't about fonts, and gtk integration does this too. We discussed changing the text too.

tsujan commented 2 years ago

But widget style isn't about fonts, and gtk integration does this too

GTK icons too. That's unfortunate. (I don't use this section; have set ~/.config/gtk-3.0/settings.ini manually and once for all.)

OK, you're right, a separate ~section~ page may be better — as the last ~section~ page, because it's non-native.

tsujan commented 2 years ago

I started to do it. Self-assigning...

tsujan commented 2 years ago

This is much cleaner, both in the GUI and in the code:

appearance1

appearance2

stefonarch commented 2 years ago

Looks good! There is still this issue I remember now.

tsujan commented 2 years ago

There is still https://github.com/lxqt/lxqt/issues/658 I remember now.

I remember it was discussed elsewhere too, and my opinion was that it was good to have it in two places. I still have the same opinion because it's needed in both GUIs. But let's not discuss it here.

ghost commented 2 years ago

Amazing work tsujan. I'm just curious - who approves merge requests? I am beginning to learn Git and I already know some C++ (mainly just C a.t.m.). I'd love to do more than just create layman's issues.

tsujan commented 2 years ago

I'd love to do more than just create layman's issues.

PRs by contributors are very welcome.

who approves merge requests?

LXQt devs.