search

lxqt / lxqt-config

Tools to configure LXQt and the underlying operating system
https://lxqt.github.io
GNU Lesser General Public License v2.1
81 stars 62 forks source link

Remember the size of lxqt-config-input dialog #820

Closed ghost closed 2 years ago

ghost commented 2 years ago
Issue

The default dimensions of lxqt-config-input's GUI should include more room for the page pane. This is the dimensions that lxqt-config-input starts with: 157998378-41415f0a-516d-4e42-b6d8-13c3105b6f54

All pages fit well in the minimum dimensions already, this would only increase the size so they have more room.

Possible solution

Increase minimum size of window to include more room. If DPI changes things too large, allow for scrollbar.

Drawbacks to solution

Code complexity and bigger dimensions on launch

System Information

lxqt-config-git - 1.0.0.25.g5ab3a64-1 5ab3a64 liblxqt - 1.0.0-1 lxqt-qtplugin - 1.0.0-2 qt5-base - 5.15.3+kde+r133-1 Qt5 style: Fusion Font: 12 Noto Sans Display linux 5.15.27-1-lts

tsujan commented 2 years ago

There's no reason to give more width to the left pane. The width is calculated correctly.

tsujan commented 2 years ago

You probably meant the height, not the width.

"LXQt Appearance Configuration" remembers its size but "Keyboard and Mouse Settings" dialog doesn't. We can't avoid scrollbars at the first run because different users may have different styles/fonts/... but we can remember the dialog size.

I'm changing the title and reopening this....

ghost commented 2 years ago

Should the height be corrected to something more reasonable? I understand now that the width/height is dynamic (corresponding to the font size). The default window dimensions appear to be the same as the minimum dimensions. Perhaps we could increase minimum dimensions to a height more reasonable.

tsujan commented 2 years ago

Searching for a "reasonable default height" isn't reasonable.