search

lxqt / lxqt-config

Tools to configure LXQt and the underlying operating system
https://lxqt.github.io
GNU Lesser General Public License v2.1
81 stars 62 forks source link

Consider LXQt theme names case-insensitively #847

Closed tsujan closed 2 years ago

tsujan commented 2 years ago

This is needed after https://github.com/lxqt/liblxqt/pull/308

tsujan commented 2 years ago

This need changes, ~for two reasons~ : (1) lxqt-config shouldn't need to know about case-insensitivity; ~and (2) it shouldn't list theme variants whose differences are only in letter cases.~

tsujan commented 2 years ago

Oh, my memory failed me: (2) isn't a problem because LXQt::LXQtTheme::allThemes() is used.

Only knowing about case-insensitivity is a logical problem.

palinek commented 2 years ago

I still think, the whole case insensitive comparison of theme directories is wrong concept.

tsujan commented 2 years ago

Superseded by https://github.com/lxqt/lxqt-config/pull/848

tsujan commented 2 years ago

I still think, the whole case insensitive comparison of theme directories is wrong concept.

Yes, I know that you compare it with MS Windows file system. But it removes unnecessary complications.

tsujan commented 2 years ago

BTW, while doing this work, I found a self-inconsistency in liblxqt. It treats theme paths and theme names on the same level when making a theme object but only uses the theme names in other places.

Fortunately, it doesn't affect any code in LXQt because, everywhere, the names are used for comparisons.