"ApplicationChooser" is not a good name

[tsujan]

In File Associations → Associations, if you select a mimetype from the left tree and press "Change..." or "Choose..." in the right pane, the "ApplicationChooser" dialog will be opened. That name may be good for C++ coding but not for appearing inside a GUI.

Please change it to "Application Chooser" — just add a space.

[stefonarch]

As it doesn't remember window size I never saw it. It looks also that it's impossible to reduce empty space in the title bar. In translation this issue is usually solved.

[tsujan]

It looks also that it's impossible to reduce empty space in the title bar

That depends on the WM and its settings, not on the app.

[tsujan]

If we want to preserve the current translations (is there any?), we should edit the ts files manually. Could you do that? Or will it be OK if they disappear and are added by translators again?

[stefonarch]

is there any?)

Yes https://translate.lxqt-project.org/search/lxqt-configuration/?offset=1&q=applicationchooser&sort_by=-priority%2Cposition&checksum=

We have working bash scripts which will remove the "type unfinished" which we used already twice already. sed -i '/></! s/translation\ type=\"unfinished\"/translation/g' *.ts or sed --in-place -re '/<translation .*type="unfinished"[^>]*>[^<]/ s/ ?type="unfinished"//' *_*.ts

[stefonarch]

Looking closer at the translations some seems to have adopted the style: "ВибирачПрограм" , "PemilihAplikasi"

[tsujan]

That's up to the translator to decide what sounds natural in his language. But "ApplicationChooser" seems like a copy-pase typo; it's the class name ;)

[isf63]

I was thinking of adding the space to https://github.com/lxqt/lxqt-config/blob/bfd534bb5d6679077c448d5109ddad43f35278f6/lxqt-config-file-associations/applicationchooser.ui#L14 but because it's not a tr( ) I got confused. I'm guessing all <name>ApplicationChooser</name> and <source>ApplicationChooser</source> in lxqt-config-file-associations/translations/* must be updated as well?

EDIT: Also, unless all translations for this are turned to type="unfinished", it'd be tricky to determine which are and aren't correct.

[tsujan]

because it's not a tr( ) I got confused

All strings (<string>...</string>) in the ui file are translatable automatically — unless <string notr="true"> is added.

and ApplicationChooser in lxqt-config-file-associations/translations/* must be updated as well?

@stefonarch does it once in a while — shouldn't be done in PRs.

If you don't make a PR, it'll be forgotten ;) Please just add a space there; no other change is needed