search

lxqt / lxqt-config

Tools to configure LXQt and the underlying operating system
https://lxqt.github.io
GNU Lesser General Public License v2.1
79 stars 60 forks source link

Put cursor settings in `"~/.Xresources"` #938

Closed tsujan closed 1 year ago

tsujan commented 1 year ago

~/.Xdefaults is the old place, altough it is also written to.

This patch fixes the problem of not being able to set the cursor (size) with lxqt-config-appearance when Xresources from /etc is read.

Credit goes to @humpity for finding the main cause.

Fixes https://github.com/lxqt/lxqt-config/issues/937

tsujan commented 1 year ago

To see the problem, edit ~/.Xresources (create it if not existing) and put a big cursor size in it, like this:

Xcursor.size: 40

Then log out and log in. After that, you couldn't restore the cursor size with lxqt-config-appearance. But if you apply the patch, you could.

NOTE: The cursor size on the title-bars of KWin won't change until the next login. That's not related to lxqt-config-appearance but to KWin.

tsujan commented 1 year ago

BTW, I didn't know from whom I should request a review — apparently, the code wasn't written by an LXQt dev.

tsujan commented 1 year ago

Rebased (merge conflict fixed).

I wanted to make a point release with this fix because, IMO, the bug was serious. But it isn't possible anymore, after the changes related to lxqt-menu-data — it should have been merged before them :(

stefonarch commented 1 year ago

That's a pity... point releases for all components involved is probably an overkill.

tsujan commented 1 year ago

point releases for all components involved is probably an overkill.

Yes, point releases should only be about critical bugs.

tsujan commented 1 year ago

@luis-pereira, thanks for the review!