search

lxqt / lxqt-config

Tools to configure LXQt and the underlying operating system
https://lxqt.github.io
GNU Lesser General Public License v2.1
79 stars 60 forks source link

Fixed primary monitor after a change in `libkscreen` #954

Closed tsujan closed 10 months ago

tsujan commented 10 months ago

By replacing Output::setPrimary() with Output::setPriority().

Fixes https://github.com/lxqt/lxqt-config/issues/925

tsujan commented 10 months ago

The changes are elementary and passed my tests with two monitors. Any objection to merging them?

ratijas commented 10 months ago

Ideally output->setPrimary should be replaced with config->setPrimaryOutput, or config->setOutputPriority for more granular approach. In fact, I was against Output::setPriority being a public method, but it was needed for config deserializers on backends.

tsujan commented 10 months ago

@ratijas, thanks for the tip. A minimal change was meant here (the next release will be in November), but yes, we should do it later.