search

lxqt / lxqt-config

Tools to configure LXQt and the underlying operating system
https://lxqt.github.io
GNU Lesser General Public License v2.1
79 stars 60 forks source link

lxqt-config-monitor: Unintrusive (hopefully) UI improvements proposal #961

Closed vc-01 closed 7 months ago

vc-01 commented 8 months ago

Greenlit by project team member.

Please see individual commit messages for detailed explanations for each change.

Refs: gh-577

tsujan commented 8 months ago

Thanks!

Since you were worried about your PR, I'm here to emphasize that it'll be reviewed (if no other dev volunteers, I'll do it). But since LXQt 1.4.0 will be released in a week or so, and we won't have enough time for testing until then, reviewing/merging will be done after the new release.

vc-01 commented 8 months ago

Thank you for your very fast response. I'm more than fine if the review takes, say a full year of time for example, after all this is an unpaid project and I'm happy that it exists at all. I was worried more about going against ideas of the project and waste time working on something to be later rejected or frowned upon. Which is especially a case for no-one-need-it-no-one-want-it UI changes. And as mentioned already, the UI for lxqt-config-monitor needs much more than what's been proposed in this PR.

-- No rush. --

tsujan commented 7 months ago

Thanks! IMO, this is much better than the current master branch. There are other problems in the config dialog too, but this PR does its job well. So, if other members find no issue in it either, it could be merged.

Before I give it a "GTM", would you please squash all commits?

vc-01 commented 7 months ago

... would you please squash all commits?

I have squashed the commits as requested.

tsujan commented 7 months ago

Assuming that there's no objection, I'm merging it — its goals are reasonable, and it works as intended.