search

lxqt / lxqt-config

Tools to configure LXQt and the underlying operating system
https://lxqt.github.io
GNU Lesser General Public License v2.1
79 stars 60 forks source link

lxqt-config-input: Fixes a FTBFS with Clang #992

Closed luis-pereira closed 2 months ago

luis-pereira commented 2 months ago

It fails to build with, at least, clang version 16.0.6.

tsujan commented 2 months ago

@luis-pereira Thanks! And sorry for the delay; will check your recent PRs tomorrow. We may also need point releases.

luis-pereira commented 2 months ago

Thanks! And sorry for the delay; will check your recent PRs tomorrow. We may also need point releases.

This one is annoying to me. Clang is my default compiler.

tsujan commented 2 months ago

What I don't get is that QVariant::QVariant(float val) exists. Why should Clang result in FTBFS?

luis-pereira commented 2 months ago

@tsujan QVariant is not the issue here. Clang is very fussy with narrowing in initializer list. That's the issue. Updated the PR to be more easily understandable, I hope.

tsujan commented 2 months ago

@luis-pereira Yes, I saw you code comment. IMO, this is much better.