search

lxqt / lxqt-notificationd

The LXQt notification daemon
https://lxqt.github.io
GNU Lesser General Public License v2.1
62 stars 38 forks source link

A better layout for config dialog #290

Closed tsujan closed 2 years ago

tsujan commented 2 years ago

As suggested by @stefonarch.

Closes https://github.com/lxqt/lxqt-notificationd/issues/289

stefonarch commented 2 years ago

Quite the same as my branch ;) I thought all the files should be renamed too, advancedsettings. → generalsettings. and basicsettings. → position. - it could be confusing later keeping the old names.

tsujan commented 2 years ago

I thought all the files should be renamed too,

The less code change, the safer. What's important is what the user sees.

stefonarch commented 2 years ago

Not even some comment for the coders in 2050 ;) ?

tsujan commented 2 years ago

Not even some comment for the coders in 2050 ;) ?

Maybe later, in a separate PR, but I don't mean 2049.