search

lxqt / lxqt-notificationd

The LXQt notification daemon
https://lxqt.github.io
GNU Lesser General Public License v2.1
62 stars 38 forks source link

Standardize desktop file #387

Closed stefonarch closed 3 months ago

stefonarch commented 3 months ago

Related https://github.com/lxqt/lxqt-config/pull/1015 The last one IMO

isf63 commented 3 months ago

One last one I think -- pavucontrol-qt has the Comment copied into GenericName. It should have its own GenericName.

stefonarch commented 3 months ago

One last one I think -- pavucontrol-qt has the Comment copied into GenericName. It should have its own GenericName.

Identical text is shown only once, but yes, we could improve it too. Feel free to make PR.

stefonarch commented 3 months ago

Btw pavucontrol can't be found by its executable in fancymenu: https://github.com/lxqt/lxqt-panel/issues/2079

Maybe:

Name=PavuControl-Qt
GenericName=PulseAudio/Pipewire Volume Control
Comment=Adjust volume levels and select audio devices
stefonarch commented 3 months ago

What about this PR?

tsujan commented 3 months ago

Oh, it may be better to change Do not disturb to 'Do not disturb' before merging (using single quotes instead of back quotes).

EDIT: Or just use do-not-disturb, without quotes.

stefonarch commented 3 months ago

I tested single quotes (also backticks first), no issue.

tsujan commented 3 months ago

I tested single quotes (also backticks first), no issue.

Right. I also tested it before suggesting it, although I didn't know what would happen on Weblate.

stefonarch commented 3 months ago

Looks like the existing translations will not be removed, I pushed pavucontrol-qt and noticed that translators got notified: https://github.com/lxqt/pavucontrol-qt/pull/279/files