search

lxqt / lxqt-notificationd

The LXQt notification daemon
https://lxqt.github.io
GNU Lesser General Public License v2.1
62 stars 38 forks source link

Possible regression: notification background is missing #406

Open Bluey26 opened 6 hours ago

Bluey26 commented 6 hours ago
Expected Behavior

LXQt notifications should have a background color, which depends on color palette assigned in lxqt-config-appearance

previous

Current Behavior

LXQt notifications lack the background, instead the text is shown over the current window.

testnotification

Possible Solution
Steps to Reproduce (for bugs)
  1. Install lastest lxqt-notificationd from source or archlinux repositories
  2. Test notifications, there is no background.
Context

I was using a mix of 2.0 and 2.1 packages, and the notification background was present in my system a few hours ago. After the update i noticed that there was no background. I decided to test a few things, and i downgraded lxqt-notificationd from 2.1-> https://github.com/lxqt/lxqt-notificationd/commit/98716f6dde32f6a7ad24a0ce0544150095923edc

After restarting the lxqt-notification daemon from session settngs, there was background present.

The issue may be related to the next commit: https://github.com/lxqt/lxqt-notificationd/commit/65c518a0b0200e840f1464846e7c7c36a2639291 which i suspected to be related because it was about translucency (that's why i have chosen a previous commit to test).

System Information
tsujan commented 5 hours ago

Not reproducible with 2.1.0.

Make sure you've compiled it against Qt 6.8.

BTW, you forgot to tell that it happened under Wayland for you; didn't it? Also, please tell which LXQt theme you use.

tsujan commented 5 hours ago

OK, you don't use any stylesheet for lxqt-notificationd — it should be the System theme. Yes, I can see it too, without that stylesheet and under Wayland.

Bluey26 commented 4 hours ago

Not reproducible with 2.1.0.

Make sure you've compiled it against Qt 6.8.

BTW, you forgot to tell that it happened under Wayland for you; didn't it? Also, please tell which LXQt theme you use.

Yes, it happens to me in Labwc (wayland).

I used the official package and also compiled it myself https://archive.archlinux.org/packages/l/lxqt-notificationd/lxqt-notificationd-2.1.0-1-x86_64.pkg.tar.zst , is the one in the arch repos.

OK, you don't use any stylesheet for lxqt-notificationd — it should be the System theme. Yes, I can see it too, without that stylesheet and under Wayland.

Yes, i use System theme, a custom version. I now see that changing it to another LXQt theme seems to provide a background according to it. I thought it was related to palette, i confused it because System theme uses color palette for the colors.

Maybe adding some custom background or css thing into system theme would solve it, not sure. System theme is special, because the notification also follows the color palette (its my favorite 😆).

tsujan commented 4 hours ago

The simple fix is here: https://github.com/lxqt/lxqt-notificationd/pull/407. Thanks for reporting!

Bluey26 commented 4 hours ago

The simple fix is here: #407. Thanks for reporting!

On the contrary, thanks to you for this quick fix, it works properly now :)

tsujan commented 4 hours ago

My second thank for testing it :)