lxqt / lxqt-panel

The LXQt desktop panel
https://lxqt-project.org
GNU Lesser General Public License v2.1
179 stars 135 forks source link

Globalkeys shortcut "Show Desktop" works only if show-desktop-plugin is added #1690

Open stefonarch opened 2 years ago

stefonarch commented 2 years ago

As shortcuts are an alternative to mouse clicking this is not optimal.

Expected Behavior

The shortcut always works.

Current Behavior

Without "show desktop plugin" it doesn't.

Possible Solution

As workaround shortcuts in WM settings work as expected.

Steps to Reproduce (for bugs)
  1. Clear shortcuts in WM settings
  2. Define shortcut for showdesktop in LXQt
  3. Try without plugin on panel
  4. No desktop shown
Context
System Information
tsujan commented 2 years ago

There isn't a problem to solve here. "Show Desktop" works by using KWindowSystem — independently of WM — and there should be a plugin that supports it.

That being said, it also depends on the WM and whether it has a command for showing desktop.. I have "Show Desktop" with KWin and without show-desktop plugin because I've added a shortcut for the command:

qdbus org.kde.kglobalaccel /component/kwin invokeShortcut MinimizeAll

Also, some WMs, like compiz-reloaded, have their own shortcut for it.

stefonarch commented 2 years ago

Afaik every WM (at least among the main 3 used) has a shortcut for this, and in fact as I don't want and need a button on the panel for that I have to use those provided by the WM.

If it's not possible technically we should inform users about that somewhere, otherwise we have again a bad user experience.

tsujan commented 2 years ago

If it's not possible technically we should inform users about that somewhere

The menu shortcut doesn't work without the main menu plugin, or the runner shortcut doesn't work when runner isn't started; etc. This isn't about bad design.

stefonarch commented 2 years ago

For the runner this is clear (one could even say it should start when invoked by shortcut), but the connection between the panel plugin and the show-desktop shortcut isn't tthat obvious, and I found out about only by case.