search

lxqt / lxqt-panel

The LXQt desktop panel
https://lxqt-project.org
GNU Lesser General Public License v2.1
184 stars 134 forks source link

Icons dragged from menu are doubled in quicklaunch #1750

Closed stefonarch closed 2 years ago

stefonarch commented 2 years ago

I was not sure to open an issue about that, but I cannot found any reason for this behavior. It happens only on one PC, and only with my normal user account. Both PCs have latest git. Icons dragged from desktop aren't doubled. Removed panel settings, same with fresh panel. Removal is normal, one icon at once.

tsujan commented 2 years ago

I can't reproduce it here.

  1. Does it happen with all menu items or with some?
  2. Is it locale-dependent or it happen with English too?
stefonarch commented 2 years ago

I can't reproduce it here.

That's the point, it's something really local here. 1) yes, I didn't test all of them but many. 2) Tested with LANG=C lxqt-panel, same issue.

The first time I saw it happen it added 3, but only once. Now I switched theme to Frost and it adds 3 again every time, and every theme I use now it adds 3. Panel is full now :)

Removed quicklaunch and readded, it adds 2 again, changed theme and it adds 3 again, changed icon set: 2 again. Going to bed...

tsujan commented 2 years ago

There should be a bug somewhere, one of those bugs, whose way of reproducing we need to find first.

tsujan commented 2 years ago

I didn't see anything wrong in drag and drop codes. I think we haven't changed them for a long time. The drag code takes only one URL from the main menu (the path of the desktop file), which is given to Quick Launch by dropping.

When you wake up, please attach your panel.conf. I might be able to see the problem with it.

stefonarch commented 2 years ago

As I mentioned: it happens with a default panel.conf too. I tried my panel.conf even on my test user.
It should be a settings issue, as the test user and the other PC are not affected. Tried also reset globalkeys settings. Don't waste too much time on this, I did already ;)

panel.conf.zip

stefonarch commented 2 years ago

I tried to DND on the desktop (or any other pcmanfm-qt window), and this is interesting: it asks "copy or link" but nothing is done and the cursor - when going again on the menu or the panel - has the "no" icon forever, until panel is restarted.

dnd

BTW I had to use LXimage-qt for the screen, found no way to include mouse cursor in screengrab.

tsujan commented 2 years ago

I tried your config file but Quick Launch was OK. I also changed the theme to Frost but didn't see a problem: Each time, only one launcher was created on dropping from Main Menu. DND on pcmanfm-qt was OK too.

Your last comment shows a fundamental problem. With the current info, I can't guess where it is: something went wrong during LXQt installation? Or is there a problem in WM, X11,...?

I hope you'll find more info, because the problem looks serious.

tsujan commented 2 years ago

BTW I had to use LXimage-qt for the screen, found no way to include mouse cursor in screengrab.

This can show a fundamental problem outside LXQt.

stefonarch commented 2 years ago

The issue is inside~/.config/lxqt - copying it to the the test user the problem appears. But didn't locate it yet.

This can show a fundamental problem outside LXQt.

You can make screenshots with the cursor with screengrab? LXimage-qt has an option for it.

tsujan commented 2 years ago

You can make screenshots with the cursor with screengrab?

Yes, of course:

sg

tsujan commented 2 years ago

The issue is inside ~/.config/lxqt

Strange! I don't know how an issue in LXQt can affect DND. Tell me if you find which config file causes it.

stefonarch commented 2 years ago

Found it: lxqt.conf, removing sections it looks like the [Qt] part was the issue, readding line by line the issue reappears with style=Oxygen.

Can you try to reproduce simply using Oxygen widget style?

stefonarch commented 2 years ago

Screengrab: I see. but you cannot include it in " Screen area"

tsujan commented 2 years ago

Can you try to reproduce simply using Oxygen widget style?

Nice catch! Oxygen is the culprit. Yes, I can reproduce it with Oxygen. Not our bug :) I think we can close this.

but you cannot include it in " Screen area"

No. The cursor can't be captured with it and that's expected.

tsujan commented 2 years ago

The problem is worse, although it isn't our problem. Now, Qt's gtk2 style and, probably, all styles belonging to qt5-styleplugins, cause an immediate crash. Don't choose gtk2! it can make the whole LXQt crash.

Something has changed in Qt5 in a backward incompatible way (in Arch/Manjaro) and so, qt5-styleplugins doesn't work. Its recompilation may fix that.

The problem with Oxygen may have a similar cause.

tsujan commented 2 years ago

I upgraded to qt5-styleplugins 5.0.0.20170311-27 and the problem with Qt's gtk2 style is fixed.

stefonarch commented 2 years ago

This is an AUR package, there's a reason for that probably. In Lubuntu 22.04 (LXQt 0.17) it's available, and no issue about crash.

This issue can be reproduced instead, after session restart only. I'll mention it in the wiki.

stefonarch commented 2 years ago

No. The cursor can't be captured with it and that's expected.

Why? Sometimes LXimage's screenshot tools is nice to have still around :)

tsujan commented 2 years ago

In Lubuntu 22.04 (LXQt 0.17) it's available, and no issue about crash.

Lubuntu = Ancient programs. The problem was caused by recent Qt upgrades in Arch.

Why?

Because of how it does it.