lxqt / lxqt-panel

The LXQt desktop panel
https://lxqt-project.org
GNU Lesser General Public License v2.1
179 stars 135 forks source link

Make Fancy Menu more keyboard friendly #1986

Closed tsujan closed 5 months ago

tsujan commented 5 months ago

Is your feature request related to a problem? Please describe.

Currently, there is no way for changing the selected category only by using keyboard.

Describe the solution you'd like

It's good that the keyboard focus is started in the search entry, but I think the following behavior needs to be implemented:

Although I use the word "should" above, what I said was only the best suggestion that came to my mind. If you have a better suggestion, please describe it. I think we need to agree on this before changing the code.

gfgit commented 5 months ago

I agree. Maybe I can do it inside the eventFilter and keep a bool flag of which view is currently focused. Don't know if can be done with standard Qt functions like key navigation

tsujan commented 5 months ago

@gfgit Please wait a little more for us to see if there's a better suggestion about how arrow keys should work — IMHO, that isn't as obvious as it may seem.

Also, I have a PR, and another one will come after it's merged.

stefonarch commented 5 months ago

I can't think of anything to change or add in this proposal, except maybe (if possible) that in the search results the first item could be highlighted always, atm it takes one up/down arrow and only then enter starts the app.

tsujan commented 5 months ago

n the search results the first item could be highlighted always

I agree, only when the search entry isn't empty.

But, IMO, there's no need to remember the previous selection without a search. It would be confusing if the previous selection was always remembered; the current behavior is quite acceptable.