search

lxqt / lxqt-panel

The LXQt desktop panel
https://lxqt-project.org
GNU Lesser General Public License v2.1
179 stars 135 forks source link

Corrected context menu position of Fancy Menu #1995

Closed tsujan closed 5 months ago

tsujan commented 5 months ago

QWidget::mapToGlobal should have been used with the viewport, not with the view itself.

Also, set the window flag explicitly because, although there seems to be no problem under Wayland, we had seen a problem in another plugin when the flags weren't set explicitly.

tsujan commented 5 months ago

@stefonarch Whether this patch fixes the problem you told me or not, it is needed, but please check if it has any effect for you.

stefonarch commented 5 months ago

Issue is here https://github.com/lxqt/lxqt-panel/issues/1996

It hasn't any visible effect, offset and issues are still the same.

tsujan commented 5 months ago

OK. I didn't expect it had any relevance to https://github.com/lxqt/lxqt-panel/issues/1996. But it's logical and simple enough; hence merging...

tsujan commented 5 months ago

BTW, also see https://github.com/lxqt/lxqt-panel/blob/1848d95fa0307d173c0f4ef05139dcbbb9eba972/plugin-volume/volumepopup.cpp#L52-L54

stefonarch commented 5 months ago

The issue is the same, both on wayland and x11.

tsujan commented 5 months ago

The issue is the same, both on wayland and x11.

The code I quoted above was just a complementary explanation; otherwise, there was no issue here under Wayland.