lxqt / lxqt-panel

The LXQt desktop panel
https://lxqt-project.org
GNU Lesser General Public License v2.1
179 stars 135 forks source link

Visible separator for Fancy Menu with all Qt styles #1997

Closed tsujan closed 5 months ago

tsujan commented 5 months ago

There were two problems in how the separators of Fancy Menu were drawn:

  1. Using a toolbar separator resulted in an invisible separator with some Qt styles because there is no guarantee that all Qt styles should draw PE_IndicatorToolBarSeparator (some may use a spacing instead);
  2. PM_DefaultFrameWidth may only be 1px with some styles, in which case, the separator might not be clearly visible with some LXQt themes (depending on the colors of Qt style).

This patch draws a separator with an opaqueness of 40%, such that it is clearly visible with all LXQt themes and Qt styles but not too bold.

tsujan commented 5 months ago

With Fusion, the separator of categories view might not be clearly visible before:

1

Now, it's clearly visible but not too much:

2

With most themes of the Kvantum widget style, the separator wasn't visible, but it is now:

3

stefonarch commented 5 months ago

Unrelated: my kvantum theme KvSimplicityDarkLight shows that blueish border on selected items:

screen_area_lun_08:34:17_

Didn't find an option to disable this.

tsujan commented 5 months ago

my kvantum theme KvSimplicityDarkLight shows that blueish border on selected items

Kvantum Manager → Configure Active Theme → Miscellaneous → Remove focus rectangles.

It reveals a minor and harmless focus problem in Fancy Menu. I might try to fix it later, but we have more important works for now.

stefonarch commented 5 months ago

Kvantum Manager → Configure Active Theme → Miscellaneous → Remove focus rectangles.

Thanks, I'm half blind with too many options ;)

tsujan commented 5 months ago

... with too many options ;)

Kvantum is like a jungle by nature. The options exposed by Kvantum Manager are only a small part of its settings.