lxqt / lxqt-panel

The LXQt desktop panel
https://lxqt-project.org
GNU Lesser General Public License v2.1
180 stars 135 forks source link

Make fancymenu default menu #1998

Closed stefonarch closed 8 months ago

tsujan commented 8 months ago

I have no problem with this, but I think we may want to wait a little longer before merging it. IMHO, at least https://github.com/lxqt/lxqt-panel/issues/2000 needs to be implemented (I'll work on it).

stefonarch commented 8 months ago

There is no haste, and it will affect only new installations or newly added users.

tsujan commented 8 months ago

I think Fancy Menu is now mature enough to be the default menu. As far as I'm concerned, you could ship this whenever it's ready.

stefonarch commented 8 months ago

IMO autoSel=true has to be added now.

tsujan commented 8 months ago

IMO autoSel=true has to be added now.

I'll have no problem with anything you see fit here.

stefonarch commented 8 months ago

I'll have no problem with anything you see fit here.

Promise? ;)

tsujan commented 8 months ago

Promise? ;)

I'm a guardian of codes. Settings exist to be chosen in ways like this. So, yes, I promise ;)

stefonarch commented 8 months ago

We could consider to add to fancymenu in the default panel already 2 or 3 default favorites: browser, filemanager and eventually email client, which call the default applications.


[Desktop Entry]
Name=Browser Web
GenericName=Default browser
Comment=Start default browser
Exec=bash -c "$(basename -s .desktop $(qtxdg-mat def-web-browser))"
Type=Application
Categories=Network;
Icon=web-browser
Terminal=false

similar for default filemanager and eventually email client. To ship in lxqt-menu-data.

tsujan commented 8 months ago

"Favorite" implies "personal". I don't think we should add any favorites by default. Instead, we can add a very short explanation inside an empty Favorites section, like: "Add your favorites by right clicking items."

EDIT: Done in https://github.com/lxqt/lxqt-panel/pull/2009

stefonarch commented 8 months ago

With https://github.com/lxqt/lxqt-panel/pull/2020 done merging now.

tsujan commented 8 months ago

Yes, Fancy Menu is ready to be used by default.

Previously I thought I wouldn't like such a menu because it would require extra clicks. But with auto-selection, it feels more comfortable than Main Menu.

stefonarch commented 8 months ago

As I mentioned often, I use shortcuts, 3-4 quicklaunch items and runner for the rest, it's easier with center screen and using keyboard only. I've a hack for a shortcut top open the menu under wayand but full keyboard navigation in the menu isn't implemented yet. But I use the menu for checking what I've installed periodically, and I like the "All application" category very much for that purpose.

tsujan commented 8 months ago

full keyboard navigation in the menu isn't implemented yet.

It'll be easy to implement if my proposal at https://github.com/lxqt/lxqt-panel/issues/1986#issue-2090312681 is acceptable.

AzumaHazuki commented 8 months ago

Would it be possible to add a 0ms/instant option for autoselection? Even 50ms feels a little laggy to me.

tsujan commented 8 months ago

Would it be possible to add a 0ms/instant option

The shorter the delay, the more CPU usage, which would practically be for nothing with < 50ms.

Even 50ms feels a little laggy to me.

If your feeling wasn't caused by auto-suggestion, you should have felt your time was wasted by all menus, because the delay of sub-menu popup is 256 ms by default, 225 with Fusion, 150 with Breeze, and 225 with GTK, the shortest delay being that of Motif, which is 96.

Menu-items may be selected instantly, but sub-menus appear with a delay. In Fancy Menu, categories are selected with a delay, but their corresponding apps are shown instantly.