search

lxqt / lxqt-panel

The LXQt desktop panel
https://lxqt-project.org
GNU Lesser General Public License v2.1
179 stars 135 forks source link

Fix plugin loader (#2052) #2053

Closed berolinux closed 2 months ago

berolinux commented 2 months ago

The lxqt-plugin binary needs to export symbols that should be visible to plugins being loaded with QPluginLoader or dlopen.

Fixes https://github.com/lxqt/lxqt-panel/issues/2052

yan12125 commented 2 months ago

Thanks for the fix, I can confirm it works. Just an issue: https://cmake.org/cmake/help/latest/variable/CMAKE_EXECUTABLE_ENABLE_EXPORTS.html says CMAKE_EXECUTABLE_ENABLE_EXPORTS is added in CMake 3.27. I'm not sure if it's too new for Linux/BSD/... distributions.

stefonarch commented 2 months ago

Indeed it's on the edge: https://repology.org/project/cmake/versions

tsujan commented 2 months ago

This may deserve a point release. Please decide what should be done. @luis-pereira, @yan12125?

yan12125 commented 2 months ago

We can use the ENABLE_EXPORTS property:

This approach looks good (not tested yet)

luis-pereira commented 2 months ago

This approach looks good (not tested yet)

Pls test. It worked on my test.

luis-pereira commented 2 months ago

This may deserve a point release. Please decide what should be done. @luis-pereira, @yan12125?

If ENABLE_EXPORTS is found to work, we should use it, IMO. It deserves a point release, IMO.

Chiitoo commented 2 months ago

This approach looks good (not tested yet)

Pls test. It worked on my test.

For what it is worth, worked for me.

Thank you!

tsujan commented 2 months ago

@luis-pereira Would you please make a PR?

luis-pereira commented 2 months ago

@tsujan Done here @berolinux Thanks for your work.

yan12125 commented 2 months ago

Superseded by #2061