lxqt / lxqt-panel

The LXQt desktop panel
https://lxqt-project.org
GNU Lesser General Public License v2.1
179 stars 135 forks source link

[Feature request] Move responsibility for device management to pcmanfm-qt (plugin-mount) #2059

Closed antis81 closed 2 months ago

antis81 commented 2 months ago

Is your feature request related to a problem? Please describe.

Different behaviour between plugin-mount and pcmanfm-qt file manager caused by using different device management systems/solutions.

Describe the solution you'd like This acts as a control ticket and discussion point to re-implement plugin-mount based on pcmanfm-qt's agnostic device management interface. Ideally it maps directly to a single feature branch (PR TBD).

Planned steps:

  1. Replace the direct calls to Solid (KIO) by calls to pcmanfm-qt interface
  2. Remove the solid library dependency from plugin-mount

Describe eventual alternatives you've considered Theres no strong point in implementing a new plugin-mount2. Having things break rather helps with possible issues in the right place in pcmanfm-qt itself.

Context

Related issues:

stefonarch commented 2 months ago

Replace the direct calls to Solid (KIO) by calls to pcmanfm-qt interface

This will make pcmanfm-qt a dependency of lxqt-panel, not desired IMO.

tsujan commented 2 months ago

Not acceptable. See https://github.com/lxqt/lxqt-panel/issues/1639#issuecomment-2094782352