lxqt / lxqt-panel

The LXQt desktop panel
https://lxqt-project.org
GNU Lesser General Public License v2.1
179 stars 135 forks source link

X11: Toggling 'Window grouping' makes all task buttons disappear #2129

Open isf63 opened 1 day ago

isf63 commented 1 day ago
Expected Behavior
Current Behavior

Toggling 'Window grouping' on X11 makes all task buttons disappear

Possible Solution
Steps to Reproduce (for bugs)
  1. Open an X11 LXQt session
  2. Have a panel with a taskbar
  3. Toggle 'Window grouping' (enabling or disabling, doesn't matter)
  4. All task buttons disappear

Restarting the X11 session fixes it

Context

X11

Wayland isn't affected

System Information
stefonarch commented 1 day ago

Confirming. I tested my old packages up to the first wayland-taskbar - all the same issue. so the cause is probably in Qt changes. I'm quite sure it worked there.

EDIT: maybe not, as in debian VM with an older Qt version it's the same.

stefonarch commented 1 day ago

The other option (don't remember in english) which puts nearby windows of the same class triggers the same issue, both on checking/unchecking. X11 only too.

tsujan commented 23 hours ago

@isf63, thanks a lot for finding and reporting this important regression!

I think the problem is in LXQtWMBackendX11::reloadWindows(); will check it.

I also found out that we have two redundant files in our git source!

tsujan commented 21 hours ago

Please try https://github.com/lxqt/lxqt-panel/pull/2131

isf63 commented 20 hours ago

Grouping on/off and "put together windows of the same class" on/off no longer triggers disappearing.

On a side note, I'm getting much larger binaries than my main install. I was curious if the size went down by removing those two redundant files.

[ ~/Programming/lxqt/lxqt-panel/build/panel] du -h lxqt-panel /usr/bin/lxqt-panel
1.8M    lxqt-panel
1.3M    /usr/bin/lxqt-panel
tsujan commented 20 hours ago

On a side note, I'm getting much larger binaries than my main install

On the contrary, the binary is a little smaller because of that removal — about 40 KiB for me. Its size is 1.4 MiB here.

isf63 commented 19 hours ago

It's probably due to different compiler flags between make and makepkg/AUR.