search

lxqt / lxqt-panel

The LXQt desktop panel
https://lxqt-project.org
GNU Lesser General Public License v2.1
194 stars 135 forks source link

mainmenu/fancymenu: Fix closing menu on "Meta" shortcut #2133

Closed palinek closed 1 month ago

palinek commented 1 month ago

In the workaround for closing the menu the Meta key is reported, whereas the shortcut in lxqt-globalkeys is Super_L.

We make the workaround even dirtier and making it close upon Meta key even if the configured shortcut is Super_L or Super_R.

Closes #2076 Closes #2132

isf63 commented 1 month ago

Tested and works, however my keyboard only has Super_L (no Super_R). If Super_L is registered in lxqt-globalkeys for the menu can Super_R erroneously trigger the same?

palinek commented 1 month ago

If Super_L is registered in lxqt-globalkeys for the menu can Super_R erroneously trigger the same?

Yes, as I've written in the comment. If the menu is open (by Super_L or mouse click), then it can be closed by Super_R, if pressed.

stefonarch commented 1 month ago

Tested too, works fine.

GTM