Fixed three bugs with multi-screen setups on Wayland

lxqt / lxqt-panel

The LXQt desktop panel

https://lxqt-project.org

GNU Lesser General Public License v2.1

193 stars 135 forks source link

Fixed three bugs with multi-screen setups on Wayland #2181

Closed tsujan closed 5 days ago

tsujan commented 6 days ago

This patch fixes three issues on Wayland:

First, if a new panel was added to another screen, it wouldn't be positioned on that screen without a module restart; i.e., an on-the-fly screen positioning was impossible.
Second, if the screen of a panel was removed and added again, that panel wouldn't be shown without a module restart.
Finally, if the screen of a panel was removed, it wouldn't be moved to an existing screen without a module restart.

Closes https://github.com/lxqt/lxqt-panel/issues/2073

tsujan commented 6 days ago

I've tested this patch with LXQt+kwin_wayland. IMO, it should be in the next point release.

Currently, I seem to be the only LXQt member that can have a multi-screen setup under Wayland. Hence not requesting a review.

@Bluey26 I've seen your good reports and tests. If you can set up a multi-screen session easily, please test this; if not, never mind; I've tested it several times.

Bluey26 commented 6 days ago

Unfortunately i only have one monitor, i think i will not be able to test it, sorry!

tsujan commented 6 days ago

Thanks for your reply, and no need to be sorry :) You've already helped LXQt a lot.

stefonarch commented 6 days ago

I can test tomorrow.

tsujan commented 6 days ago

Removing the output (disconnect) its panels won't be moved to the remaining screen

It shouldn't according the original code, and this PR isn't about that.

stefonarch commented 6 days ago

this PR isn't about that.

from the issue:

If disconnecting the monitor with a panel on it this will not be moved automatically to the other monitor, panel module restart is needed too.

I'm quite sure under x11 panels are moved on connect AND disconnect.

tsujan commented 6 days ago

You have great expectations about this PR ;) I'll see if there's a short way of doing it here.

tsujan commented 6 days ago

Done. It made the patch a little simpler too.

stefonarch commented 6 days ago

Cool, will test tomorrow (really tomorrow).

tsujan commented 6 days ago

(really tomorrow)

Now that you got your external monitor, I'm be happy with any time :) No rush.