lxqt / lxqt-powermanagement

Power management module for LXQt
https://lxqt.github.io
GNU Lesser General Public License v2.1
27 stars 29 forks source link

Battery monitor settings disabled only on first run #272

Closed stefonarch closed 3 weeks ago

stefonarch commented 3 years ago

At first login on a machine without battery a info is displayed: "Could not find any battery, battery monitor disabled" and it works.

But when checking later the corresponding box in lxqt-config-powermanagement the same message will show up immediately, but the checkbox will remain checked. At next login the same message will be showed again, until the user manually disables it.

Expected Behavior

According to the message, it should be disabled in the setting.

Current Behavior

It is always active

Possible Solution

Do not show any battery or lid related setting (or only greyed out) when no lid and/or no battery is present, as in https://github.com/lxqt/lxqt-powermanagement/issues/261

Steps to Reproduce (for bugs)
  1. On a PC Desktop or in Virtualbox activate battery monitor.
  2. A message will be displayed, saying it will be disabled.
  3. Control the settings, still active
  4. Restart session, again the message and no result.
System Information
tsujan commented 3 weeks ago

The report is very old and unattended. Frankly, I don't get what was the problem. When you check it, you want it; there's no reason for it to be unchecked automatically (think of an old laptop whose battery is temporarily removed).

EDIT:

According to the message, it should be disabled in the setting

"battery monitor disabled" means it doesn't work ;)

stefonarch commented 3 weeks ago

Don't remember well either, the issue is that there are 3 things mixed in "power-management": lid, battery, idle. On a PC it's not possible to have the icon in the tray (pause idleness). I didn't see any messages and idleness works, for pausing I had to write a custom script/icon in quicklaunch.