search

lxqt / lxqt-qtplugin

LXQt Qt platform integration plugin
https://lxqt.github.io
GNU Lesser General Public License v2.1
24 stars 14 forks source link

build: Add option for StatusNotifierItem usage #11

Closed palinek closed 7 years ago

palinek commented 8 years ago

Use our StatusNotifierItem implementation only when forced by build system (packager) or if Qt < v5.6.1

fixes lxde/lxqt#1082

paulolieuthier commented 8 years ago

GTM.

paulolieuthier commented 8 years ago

Actually, wait a minute. After restart, all Qt apps (except sni-qt's and KDE's) appear on systemtray rather than on the status notifier. I'm talking about lxqt-powermanagement, Qlipper and transmission-qt.

paulolieuthier commented 8 years ago

Can someone confirm the bug?

palinek commented 8 years ago

@paulolieuthier I've made the hack for testing... please have a look.

I realy don't know how can the internal implementation be used "in normal way" by 3rd party

luis-pereira commented 8 years ago

I'm not been following this, working in the screensaver issue. Done now. But, how can we rely in an not exported class ?

palinek commented 8 years ago

But, how can we rely in an not exported class ?

That's the question :)

paulolieuthier commented 8 years ago

I'll test tonight, but I don't think we should rely on that.

paulolieuthier commented 8 years ago

Still doesn't work for me,

luis-pereira commented 8 years ago

It doesn't work for me either.

luis-pereira commented 8 years ago

Update: After removing the sni-qt package, this is the result: **lxqt-powermanagement and qlipper left to the taskar (in the status notifier plugin) and aptset-qt, keepassx, megasync and skype at the right (in the systray plugin). screen-2016-07-03-15-16-00

palinek commented 8 years ago

Still doesn't work for me,

Strange. Here it places the icons into SNI plugin.

Can you test in lxqt-qtplugin's build directory with something like QT_QPA_PLATFORM_PLUGIN_PATH="$(pwd)/src" lxqt-powermanagement (with stopping the pre-existing instance of lxqt-powermanagement first)?

paulolieuthier commented 7 years ago

I missed this one. Will test it soon.

paulolieuthier commented 7 years ago

Well, it's working here.

palinek commented 7 years ago

Well, it's working here.

Are you testing with the @16f760d? Because it is just a hack for testing. I wouldn't recomend to merge such fragile dependency into master.

paulolieuthier commented 7 years ago

Are you testing with the @16f760d?

Yes. I'm just confirming it works. I agree we shouldn't merge this, but close it.

palinek commented 7 years ago

FYI: https://bugreports.qt.io/browse/QTBUG-55310