search

lxqt / lxqt-qtplugin

LXQt Qt platform integration plugin
https://lxqt.github.io
GNU Lesser General Public License v2.1
24 stars 14 forks source link

Update the icon theme name cached inside QIconLoader properly. #16

Closed PCMan closed 7 years ago

PCMan commented 7 years ago

The change made in 78735d5c38d2a1db221e1b3a71ec6c69ccf544e9 replaced QIconLoader with XdgIconLoader, but the original QIconLoader::instance()->updateSystemTheme() should not be deleted. Internally XdgIconLoader and the Qt5 built-in QIconLoader have separate icon theme name settings. So when the icon theme name is changed, you have to notify both. Without the fix, after you change the icon theme, QIcon::themeName() always returns the old icon theme. @luis-pereira Please help review the PR. Thank you.

palinek commented 7 years ago

@PCMan @luis-pereira IMO we should reuse the Qt implementation to store information about current theme etc.... please, consider the lxde/libqtxdg#110

luis-pereira commented 7 years ago

@PCMan https://github.com/lxde/libqtxdg/pull/110 got in. This one is not needed anymore. @palinek @PCMan Good job.