search

lxqt / lxqt-qtplugin

LXQt Qt platform integration plugin
https://lxqt.github.io
GNU Lesser General Public License v2.1
24 stars 15 forks source link

Remove unused parameter from onServiceOwnerChanged #25

Closed jubalh closed 7 years ago

jubalh commented 7 years ago

Seems that they are not needed.

palinek commented 7 years ago

I personally would just comment the unused parameter names (or use the Q_UNUSED macro)... but GTM

tsujan commented 7 years ago

I wanted to say exactly what @palinek said.

jubalh commented 7 years ago

@palinek, @tsujan better? What's better about this approach (curious)?

palinek commented 7 years ago

What's better about this approach (curious)?

Just that the signal provides this information... and in the future you (the developer) can spot it directly while looking at the slot w/o knowing anything about the connected signal...nothing more.

But as I said... it was GTM even before.