search

lxqt / lxqt-qtplugin

LXQt Qt platform integration plugin
https://lxqt.github.io
GNU Lesser General Public License v2.1
24 stars 14 forks source link

Handle the new hint ShowShortcutsInContextMenus #30

Closed tsujan closed 6 years ago

tsujan commented 6 years ago

Fixes https://github.com/lxde/lxqt/issues/1426.

ShowShortcutsInContextMenus is false by default and, contrary to it name, it isn't just about context menus.

towhee commented 6 years ago

Why can't you this optional? Modern ui are moving away from the classic main menubars.

tsujan commented 6 years ago

Modern ui are moving away from the classic main menubars.

"Modern"?! We stick to the classic.

towhee commented 6 years ago

Seriously I'm trying to understand Qt's thinking here. Qt goes to great effort to allow users to customize the app appearance with styles and style sheets. Why limit the user? I understand your change as the default behavior - I just want it to be optional.

How about adding setShowShortcutsInContextMenus(bool)

Pretty please :*)

tsujan commented 6 years ago

I, for one, never have problem with more customization -- and my PRs prove that -- but this patch isn't about customizability. Qt devs changed a default behavior in a backward incompatible way and without caring about usibility (I guess they didn't think about the side effects of their decision for Linux). This patch just reversed that.

If removal of shortcuts in context menus by default is called "modern", then "modern" isn't a good thing.