search

lxqt / lxqt-qtplugin

LXQt Qt platform integration plugin
https://lxqt.github.io
GNU Lesser General Public License v2.1
24 stars 14 forks source link

Fix icon colorizing at startup #32

Closed tsujan closed 6 years ago

tsujan commented 6 years ago

Fixes https://github.com/lxde/lxqt/issues/1445.

palinek commented 6 years ago

GTM

palinek commented 6 years ago

Oh boy... actually this is not good, because the createIconEngine() is called for (almost) each icon, that is created by the QIcon::fromTheme() :(

We should put the setFollowColorScheme() call into the constructor after loading the configuration.

tsujan commented 6 years ago

@palinek Read this: https://github.com/lxde/lxqt-qtplugin/pull/33#issuecomment-365238215

tsujan commented 6 years ago

Oh boy... actually this is not good, because the createIconEngine() is called for (almost) each icon,

And setFollowColorScheme does nothing if the variable in question isn't changed.