search

lxqt / lxqt-qtplugin

LXQt Qt platform integration plugin
https://lxqt.github.io
GNU Lesser General Public License v2.1
24 stars 14 forks source link

Support the StatusNotifierItem spec natively #5

Closed paulolieuthier closed 8 years ago

paulolieuthier commented 8 years ago

This is a work in progress. Besides a few TODO notes left in the source code, we still need to make the apps listen to the StatusNotifierWatcher in case the panel restarts.

Fixes lxde/lxqt#817.

paulolieuthier commented 8 years ago

This should be close to idea now. The only real feature missing now, IMO, is the ability to hide inactive icons.

paulolieuthier commented 8 years ago

@pmattern @palinek @agaida let's test it.

pmattern commented 8 years ago

Just tested the latest three commits (... 39037e8) of lxqt-qtplugin branch sni, lxqt-panel lxde/lxqt-panel@d68fb1f`, Arch i686 and x86_64: no problems, but I couldn't see any difference compared to lxqt-qtplugin commit ca7f30a and the same commit of lxqt-panel as discussed yesterday. So do the applications I'm using eventually not make use of the new features provided by those three commits or is there something else missing?

Agree that auto-hiding unused icons would be something fine to have, btw.

paulolieuthier commented 8 years ago

Those last three commits were only to implement missing features (the PR is tagged as WIP, after all). Most probably the applications you're running are not using those features. Most of them don't. The last commit, however, is very important: if you restart lxqt-panel, the icons will detect the new instance now.

paulolieuthier commented 8 years ago

Removing the WIP tag, as it's GTM IMO. The hiding inactive icons feature can be done later.

paulolieuthier commented 8 years ago

Oops.

pmattern commented 8 years ago

last commit, however, is very important: if you restart lxqt-panel, the icons will detect the new instance now.

Confirmed. This is implemented in 39037e8 but not in 7981819 yet. Agree the auto-hide stuff isn't necessary right now at all, lack of new features is explained by missing support by applications.

All in all GTM, IMO.