search

lxqt / lxqt-qtplugin

LXQt Qt platform integration plugin
https://lxqt.github.io
GNU Lesser General Public License v2.1
24 stars 14 forks source link

Bump minimum required Qt version to 5.15 #71

Closed luis-pereira closed 3 years ago

luis-pereira commented 3 years ago

Part of https://github.com/lxqt/lxqt/discussions/1974.

tsujan commented 3 years ago

It isn't important but wasn't Q_DECL_OVERRIDE (instead of override) for old times?

luis-pereira commented 3 years ago

It isn't important but wasn't Q_DECL_OVERRIDE (instead of override) for old times?

@tsujan Did not understand what you meant.

tsujan commented 3 years ago

Q_DECL_OVERRIDE is equal to C++11's override. As far as I know, Qt added it when C++11 was optional (= "old times"): If a project was built with C++11 options, it did the job of override; if not, it had no effect.

tsujan commented 3 years ago

In short, I meant changing it to override in new codes.

luis-pereira commented 3 years ago

I'm not a fan of doing only one thing in a commit. Yes, override should be used, of course.