search

lxqt / lxqt-session

The LXQt session manager
https://lxqt.github.io
GNU Lesser General Public License v2.1
57 stars 52 forks source link

session: Add FreeBSD reaper logic implementation #377

Closed palinek closed 3 years ago

palinek commented 3 years ago

I'm not fully sure about the libutil... I couldn't find any information, if it could be installed in specific directory (and also found no pkg-config definition file) => the link is only hardcoded.

palinek commented 3 years ago

@jsm222 please, review/test...

jsm222 commented 3 years ago

@jsm222 please, review/test...

Thanks. Will do as soon as possible.

jsm222 commented 3 years ago

I tested this, it sends TERM to child processes correctly. But testing kill -s TERM <featherpadpid> to simulate the reaper feature terminates Featherpad without noticing the user of unsaved changes.. Please let me know if I am testing correctly.

palinek commented 3 years ago

Yes, you're testing correctly. How applications react to the received SIGTERM is beyond the scope of lxqt-session handling.

tsujan commented 3 years ago

Please merge it if it works under *BSD. As far as Linux is concerned, there's no change other than an additional loop, whose effect should be negligible.

jsm222 commented 3 years ago

FYI I plan to downstream https://github.com/lxqt/lxqt-session/commit/12619579a3d023dbb2161c9c27e49538fae4b428.patch for lxqt-session 0.17.1 for freebsd. So a new point release is not necessary for FreeBSD's sake.. BTW, I am almost done on 0.16 -> 0.17 update of ports

tsujan commented 3 years ago

@palinek Closed by mistake? Or intentionally?

palinek commented 3 years ago

It's in master -> 669251f5e0b95d4c9209137932f98eccefe25cff

tsujan commented 3 years ago

Oh, good.