lxqt / lxqt-session

The LXQt session manager
https://lxqt.github.io
GNU Lesser General Public License v2.1
57 stars 52 forks source link

-c option not working for lxqt-session #467

Open stefonarch opened 1 year ago

stefonarch commented 1 year ago

I noticed that while testing a different config file under wayland, with lxqt-session -c /home/stef/.config/lxqt-wayland/session.conf.

Expected Behavior

-c option works, write and read

Current Behavior

It doesn't

Steps to Reproduce (for bugs)
  1. Use a different location, restart session
  2. Change some setting and look at the timestamps or settings in both session.conf
Context
System Information
tsujan commented 1 year ago

Yes, there are three problems in the -c option:

  1. The function SessionApplication::setConfigName() doesn't read its argument (such mistakes happen when a variable name is used for the argument name).
  2. Even if the above-mentioned issue is fixed, the other parts of the code will ignore it. For example, the settings won't be written to the config file specified by the -c option.
  3. The environment variable LXQT_SESSION_CONFIG set by that function will be seen by LXQt::PowerManager::PowerManager() as a config name, not a path.
stefonarch commented 5 months ago

We could just remove the -c option in `lxqt-session --help'.