search

lxqt / lxqt-session

The LXQt session manager
https://lxqt.github.io
GNU Lesser General Public License v2.1
57 stars 51 forks source link

Use layershell for leave dialog on wayland #509

Closed stefonarch closed 5 months ago

stefonarch commented 6 months ago

Looks that in README.md white spaces got removed too.

tsujan commented 6 months ago

Looks that in README.md white spaces got removed too.

Not completely. If you've used FeatherPad, it knows how to remove only redundant spaces from markdown.

Will review the patch soon. Thanks!

tsujan commented 6 months ago

With your permission, I might add commits to the PR, for fixing the above-mentioned issue.

tsujan commented 6 months ago

I added a commit. It's completely centered now. Please check it.

stefonarch commented 6 months ago

Good changes, it's now also impossible to gain keyboard focus using shortcuts or switch desktops which wasn't 100% previously. GTM

Didn't test under X11 but should be fine as before.

tsujan commented 6 months ago

Didn't test under X11 but should be fine as before.

Yes. Nothing has changed about X11. But a quick test would be good — magic sometimes happens ;)

stefonarch commented 6 months ago

Tested under x11, all fine but I noticed that keyboard focus can be changed to other applications and can't be restored to the leave window which reacts to mouse only then.

tsujan commented 5 months ago

@stefonarch Can we merge this now? It was OK as far as I tested.

stefonarch commented 5 months ago

Tested all the time, no issues found.