search

lxqt / lxqt-session

The LXQt session manager
https://lxqt.github.io
GNU Lesser General Public License v2.1
55 stars 52 forks source link

Added wayland session #519

Closed stefonarch closed 5 days ago

stefonarch commented 1 month ago

Atm it needs in session.conf for example compositor=labwc. Check if VM detection can be improved, testing it and use it for all wlroots based compositors.

Will make a PR for the GUI when https://github.com/lxqt/lxqt-session/pull/517 is merged.

immagine

The shipped configurations may need more checks too.

Should we keep "LXQt Desktop" or use "LXQt (X11)"?

It looks like we hadn't updated KF5 version check.

tsujan commented 5 days ago

IMHO, lxqt-session isn't the appropriate place for desktop entries, scripts and config files related to specific Wayland compositors. I suggest we make a separate LXQt repository (e.g., lxqt-wayland) and put these files in it.

Most importantly, lxqt-session should remain modular. I use it with LabWC by following @stefonarch's works, and I have two other sessions for Wayfire and kwin_wayland with it. That shows how modular it is :) So, let's keep it so and not include WM-specific files in it.

stefonarch commented 5 days ago

I could agree with it, but we would need to tell this is in GUI maybe as we'll have a settings for something that the user will not find.

I mean here:

immagine

tsujan commented 5 days ago

The GUI code must be written in such a way that it shows possible options if found and disable them otherwise.

I can't tell yet if that's possible with the current arrangement, because I haven't looked into it, but we always find a way ;) Actually, we already have a fallback method, by creating separate Wayland sessions with the scripts in your repository. But yes, I know that you want a unified method...

stefonarch commented 5 days ago

It's not only the compositor but also the screenlocker to set in the GUI.

It would be perfect if the wayland page in the GUI is only shown if the lxqt-wayland package is installed.

Replaced by https://github.com/lxqt/lxqt-wayland/ .

stefonarch commented 5 days ago

One option could be a minimal GUI lxqt-config-waylandsession shipped in lxqt-wayland. But it's a bit ridiculous, with only 2 settings.

If hiding is impossible just a textbox saying "lxqt-wayland package needs to be installed` it the best way IMHO.

tsujan commented 5 days ago

But it's a bit ridiculous, with only 2 settings.

To me, it's a good idea, at least as a start point. It'll make it possible to test this approach without making changes to lxqt-session.

stefonarch commented 5 days ago

I think we need more opinions about it, mentioned it in the brainstorm discussion.

tsujan commented 5 days ago

I didn't mean that the GUI shouldn't be here — IMO, this is a good place for it if the scripts and other files don't come with it — but that a separate GUI is a good idea for testing without touching lxqt-session.