search

lxqt / lxqt-session

The LXQt session manager
https://lxqt.github.io
GNU Lesser General Public License v2.1
55 stars 52 forks source link

Fix errors in KF6 check #521

Closed stefonarch closed 3 weeks ago

tsujan commented 3 weeks ago

~Can we make a point release at all, after of https://github.com/lxqt/lxqt-session/commit/eef7e778419d0242c430c14b82fcb2f591e8731d? Could you test with the released LXQt? I know, it's hard and boring; so, if you can't test, we won't make a point release.~

EDIT: Since it isn't critical, there's no need to a point release.

Chiitoo commented 3 weeks ago

It is still checking for KF6, it just doesn't care about the version since , so I suppose it shouldn't be possible for it to fail as long as KF6 is around.

The other way around would be a bit more noticeable. :]

(I also tried it on 2.0.0 quick-like, and it does seem to be fine (just applying the patch, configuring, and compiling.)

tsujan commented 3 weeks ago

It is still checking for KF6, it just doesn't care about the version since

Yes, the second mistake neutralized the first one ;) Although the issue seems bad on the coding level, it's harmless for 2.0.0.