search

lxqt / pcmanfm-qt

File manager and desktop icon manager (Qt port of PCManFM and libfm)
https://lxqt-project.org
GNU General Public License v2.0
424 stars 112 forks source link

[Feature request] Implement org.freedesktop.FileManager1 DBus interface #1194

Closed probonopd closed 2 years ago

probonopd commented 4 years ago
Expected Behavior

When I select "show in folder" for a download in a browser, the Downloads folder should be opened and the downloaded file should be selected.

Current Behavior

When I select "show in folder" for a download in a browser, then only the Downloads folder opens but I have to search for the downloaded file manually, which can be quite annoying if I don't sort by date.

Possible Solution

Looks like GNOME and KDE use https://www.freedesktop.org/wiki/Specifications/file-manager-interface/, org.freedesktop.FileManager1 DBus name and the /org/freedesktop/FileManager1 object path.

Looking at https://github.com/linuxdeepin/dde-file-manager/search?q=dbusfilemanager1 the implementation seems to be relatively straightforward.

And e.g., Chromium implements it: https://chromium.googlesource.com/chromium/src/+/master/chrome/browser/platform_util_linux.cc

Since pcmanfm-qt is all about XDG standards, I'd ask for consideration to implement this feature.

Context

My downloads folder is always full and it is annoying that pcmanfm-qt cannot do what other file managers do in this regard.

tsujan commented 4 years ago

This feature request looks valid to me.

PRs would be appreciated.

tsujan commented 4 years ago

@probonopd, can I assign it to you?

probonopd commented 4 years ago

I will answer here once I am ready to work on it. Maybe someone else can do it faster than me.

tsujan commented 4 years ago

OK.

I don't think I'll have time to work on it soon but I hope you'll do it. However, there's no rush. Take your time!

probonopd commented 3 years ago

@mszoek is making progress on this:

https://github.com/mszoek/Filer/commit/8a2817cdc4ca18c7d3e4edf5232460197d717edf and https://github.com/mszoek/Filer/commit/b9091431d09480fc529dc63d5f3656636d2fbb41

probonopd commented 3 years ago

It is implemented in Filer now.

Chromium:

https://user-images.githubusercontent.com/2480569/133944490-a0e28017-79b0-4fd0-9e9d-7661f905cde7.mp4

ahsand97 commented 2 years ago

is anyone working on this for PcManFM? or are PRs welcome?

tsujan commented 2 years ago

PRs are always welcome.

probonopd commented 2 years ago

@ahsand97 while I am not working on PRs for PCManFM, you could have a look at what we did in Filer (a fork of PCManFM) and backport that to PCManFM if you like.

probonopd commented 2 years ago

Thank you @ahsand97 and @tsujan. Nice to see this implemented! :+1: