search

lxqt / pcmanfm-qt

File manager and desktop icon manager (Qt port of PCManFM and libfm)
https://lxqt-project.org
GNU General Public License v2.0
414 stars 113 forks source link

Add "Create Launcher" to Tools menu #1340

Closed Val6789 closed 3 years ago

Val6789 commented 3 years ago

Currently one can create launchers (.desktop files) by right clicking on the desktop and sleecting the "create launcher" option in the context menu.

However, this is only possible on the desktop and not in the pcmanfm-qt windows.

Possible Solution

Add the option of creating .desktop files in any pcmanfm-qt window. This could be done by moving the "Create launcher" to the "Create new" submenu in the context menu as such:

example

Steps to Reproduce (for bugs)
  1. Right click on any pcmanfm-qt window or use the file menu
System Information
tsujan commented 3 years ago

However, this is only possible on the desktop and not in the pcmanfm-qt windows.

Not true. Drag and drop a menu item wherever you want.

Add the option of creating .desktop files in any pcmanfm-qt window

Only Desktop is a special place. If you want shortcuts inside other folders, there are different ways (DND from main menu or copy-paste from Desktop). Cluttering the right click menu with redundant items isn't a good idea.

tsujan commented 3 years ago

There is an acceptable possibility: adding Create Launcher to the Tools menu of pcmanfm-qt and not to the context menu. A simple code refactoring will do it.

Reopening and changing the title....

Val6789 commented 3 years ago

My proposal is to add the create launcher option to the "Create new" submenu. This way, it will not clutter the main context menu et imo it fits well with the rest of the file creation (new folder/now empty file) menu choices.

tsujan commented 3 years ago

My proposal is to add the create launcher option to the "Create new" submenu

Yes, I know. There can be several template menu-items there; hence not cluttering it. But thanks for the general idea!

I implemented it here and will make a PR soon. I'd like to have it in 0.17 (which will be released soon) but should ask other LXQt members whether they have no objection.

tsujan commented 3 years ago

The PR: https://github.com/lxqt/pcmanfm-qt/pull/1341